Repository navigation
Issue #543 : string.match returns nil when there is no match - #544
Open
eldologuzzo wants to merge 1 commit into
Open
eldologuzzo wants to merge 1 commit into
eldologuzzo wants to merge 1 commit into
Conversation
strMatch pushed LNil but returned 0, so no value reached the caller and tonumber(s:match(...)) failed with "value expected". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation matches Lua 5.1 semantics and is adequately covered by regression tests.
0 open findings
What changed in this PR
Fixes string.match to return one explicit nil result when no match is found, matching Lua 5.1 behavior.
Changes:
- Returns the pushed
LNilvalue fromstrMatch. - Adds regression coverage for result count and
tonumber(nil)behavior.
| File | Description |
|---|---|
stringlib.go |
Corrects the no-match return count. |
_glua-tests/strings.lua |
Adds regression assertions for issue #543. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #543 .
Changes proposed in this pull request:
strMatchpushedLNilwhen there is no match but returned 0, sostring.matchreturned no value instead ofnil(Lua 5.1 returnsnil). Code such astonumber(s:match("(%d+)"))failed with "value expected"._glua-tests/strings.lua: fails on current master and passes with this change.go testpasses.🤖 Generated with Claude Code