Repository navigation
docs(ui): reconcile shadow dom release contract - #450
Conversation
🦋 Changeset detectedLatest commit: 1d85e9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@greptileai review |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
camrun91
left a comment
There was a problem hiding this comment.
looks good. the release story, the adr move and the demo removal all check out, and i didn't see any runtime change. two non-blocking notes inline, both about release notes and docs. nothing here should hold the merge.
.changeset/coordinated-shadow-dom-rollout.md
non-blocking: with the prototype changeset gone, only ui has major-release prose. the fixed group still takes core and hooks to 3.0.0, but hooks' changelog will just say "updated dependencies", and core's will only show the fuzzy-lions-attribute minor note under a major heading. could we add a one-line major changeset for core and hooks, something like "version aligned with ui 3.0.0; no api changes in this package", so consumers aren't left wondering what broke?
🚨 Breaking change detected — signoff required for
|
|
I confirm that this is an intentional breaking change, and I have read the release procedures. I understand and have documented its impact upon release. v3.0.0 db3d8946f275a315 🚀 |
Summary
0007and adopt the automatic Shadow DOM decision as ADR0010Requirement evidence
pnpm changeset status --verbosereports core, hooks, and UI at3.0.0; no prototype summary is assigned to core or hooks.0007; Shadow DOM is0010-automatic-shadow-dom-style-isolation.md, titled# 10. Automatic Shadow DOM style isolation, with statusAccepted; all in-repo references resolve.VerseSelectionstory uses the internalShadowRootHost/ReuseShadowBoundaryseam and locates the action popover from the scripture root before exercising highlight and copy.onChangeis inconsistent, so the implementation retainsonInputwith neutral comments.Review scope
Required outcomes
Permitted support work
Non-goals
Please treat a finding as blocking only when it identifies an unmet in-scope requirement, a documented repository-standard violation in added or modified code, or a concrete regression or defect caused or worsened by this diff. Label other valid improvements as non-blocking follow-ups.
Verification
pnpm lint— passedpnpm typecheck— passedpnpm build— passedpnpm test— passed; all 6 tasks, including UI 52 files / 590 testspnpm changeset status --verbose— core, hooks, and UI resolve to3.0.0; no prototype prose is assigned to core or hooksgit diff --check— passedCompatibility notes
0007keeps its established commitlint path; the branch-only Shadow DOM ADR moves to the next available number.Review audits
Jira
YPE-6215


Confidence Score: 5/5
This PR appears safe to merge.Summary
This PR brings Shadow DOM release notes and consumer guidance into agreement.
No actionable new issues or repository-rule violations were found. No previous review threads were supplied.
Reviews (7) · Last reviewed commit: "docs(ui): address shadow dom review feed..." · Reviewed by Greptile