fix: Scope store service instances to requests - #17
Merged
Merged
Conversation
aklinker1
force-pushed
the
request-scoped-stores
branch
from
October 2, 2026 13:30
7c43c6c to
0a5df9e
Compare
aklinker1
marked this pull request as ready for review
October 2, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #14. Services were transient before, which is technically fine, as long as you're careful about when the different stores are accessed.
queue/src/dependencies.ts
Lines 25 to 40 in 01ae573
Now they're scoped and recreated at most once each request, so we don't have to be as careful about how/when they're accessed.
Additionally, I've made the
storesobject into getters so each store is only resolved when it is needed.