Repository navigation
perf(deps): require workshop-rs 1.18.0 - #776
Merged
Merged
Conversation
workshop-rs 1.18.0 borrows the cached gameplay catalog in the settings parser instead of cloning it per hero name match. On the Bastion compiled output (471 KB zh-CN) a raw Workshop check drops from about 0.56 s to about 0.20 s warm. Fixes #775
github-project-automation
Bot
moved this from Backlog
to Done
in Make Workshop Great Again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #775
Raises the
workshop-rsrequirement to 1.18.0 and updatesCargo.lock(onlyworkshop-rsmoves). No code changes.Measured on the Bastion compiled output (
main.ow, 471 KB, 8,213 lines, zh-CN; release build, raw Workshopcheck, 5 runs):Deviation from the Issue's acceptance text: the tree has no allocation counter, so the "below 250 MB allocated" criterion was checked indirectly through wall time. The earlier counting-allocator run with the fix linked showed wright-side allocation falling from 790 MB to 158 MB for the same command.
cargo fmt --check,cargo clippy --workspace --all-targets -D warningsandcargo test --workspacepass with no test changes.