Repository navigation
ci: gate the parser and catalog library on a WebAssembly build - #536
Merged
Merged
Conversation
Run cargo check for wasm32-unknown-unknown on workshop-rs --lib so a native-only dependency fails CI. Fixes #519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
wasm-checkCI job that runscargo check --locked -p workshop-rs --lib --target wasm32-unknown-unknown.The parser and catalog both live in the
workshop-rslibrary crate, so that one crate is the scope. The CLI and theworkshop-catalog-genbinary are native tools and are excluded.Verification:
miowithnetmade the check fail (This wasm target is unsupported by mio). The change was reverted.Fixes #519