Repository navigation
chore: raise the minimum supported Rust version to 1.88.0 - #529
Merged
Merged
Conversation
Raise rust-version, the CI MSRV matrix entry, the catalog-check toolchain and the AGENTS.md pre-push gate to 1.88.0, and inline format arguments that Clippy 1.88 flags. Fixes #520
With rust-version 1.88.0, stable Clippy flags collapsible ifs that let-chains now express.
Teakowa
added
the
semver-exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #520. Part of wrightkit/.github#101.
rust-version, the CIRust (1.88.0)matrix entry, thecatalog-checktoolchain and theAGENTS.mdpre-push gate all name 1.88.0. Clippy 1.88 promotesuninlined_format_args; the 4 sites it flags are inlined (mechanicalclippy --fix).Verified locally on 1.88.0:
clippy --workspace --all-targets --all-features -D warningsclean; 676 tests pass, 0 fail.Not yet confirmed: that the CI MSRV job really runs 1.88.0 depends on wrightkit/.github#109 (the shared toolchain assertion) being on
main.