Repository navigation
test(provider): make the syntaxError classification exhaustive (#591) - #593
Merged
Merged
Conversation
The DOCUMENT_SYNTAX_CODES allowlist shipped incomplete twice (#587, #588): every omission silently returned valid:true for malformed documents. Adds EXCLUDED_CODES plus NON_DIAGNOSTIC_LITERALS and a unit test scanning all kebab-case literals in ../opy-rs/src — every diagnostic code must appear in exactly one list, so a new code fails until a reviewer classifies it. The deferred classes are documented on the list itself. Fixes #591
This was referenced Oct 19, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXCLUDED_CODES(every emitted diagnostic code that must not producesyntaxError, grouped with documented deferral reasons) andNON_DIAGNOSTIC_LITERALSalongsideDOCUMENT_SYNTAX_CODES.syntax_error_classification_is_exhaustive: scans all kebab-case string literals incrates/opy-rs/src(excluding test dirs), skipping comments/raw strings, and asserts every emitted code-shaped literal appears in exactly one of the three lists — unclassified new codes and stale listed codes both fail.Test plan
cargo test -p opy-provider— 69/69 incl. the new exhaustive testcargo fmt --all -- --check,cargo clippy -p opy-provider --all-targets -- -D warnings,git diff --check