Repository navigation
docs(lessons): record the incomplete-allowlist class from the validateEdits respec - #590
Merged
Merged
Conversation
…eEdits respec opy-rs#578's DOCUMENT_SYNTAX_CODES allowlist merged with omissions; opy-rs#587 and #588 each found more document-local codes silently returning valid:true. Same class twice in one day - escalated.
Teakowa
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/LESSONS.mdentry for the fast-recurring class observed 2026-10-18: a hand-built allowlist that redefines a contract's scope merged incomplete, and each omission silently accepted input the contract must reject.DOCUMENT_SYNTAX_CODESin fix(provider): scope lpp/validateEdits syntaxError to document-local malformation #578 omitted document-local codes; fix(provider): count string-entity lexer errors as validateEdits syntaxError #587 and fix(provider): count directive-malformation and enum-increment as syntaxError #588 each found more that returned{"valid": true}.Test plan
git diff --check