Skip to content

fix(protocol): enforce request IDs and params - #85

Closed
dannyward630 wants to merge 3 commits into
wrightkit:mainfrom
dannyward630:fix/issue-79-request-shape-validation
Closed

dannyward630 wants to merge 3 commits into
wrightkit:mainfrom
dannyward630:fix/issue-79-request-shape-validation

Conversation

@dannyward630

@dannyward630 dannyward630 commented Oct 15, 2026 •

Copy link
Copy Markdown

What changed

  • Reject non-null request IDs that are not strings or integers with JSON-RPC -32600 and a null response ID.
  • Preserve arbitrary-precision integer IDs exactly, including values outside the signed and unsigned 64-bit ranges.
  • Preserve LPP's notificationNotSupported response for missing or null IDs.
  • Require params to be present and an object, returning -32602 for initialized requests with invalid params.
  • Apply notInitialized and alreadyInitialized lifecycle errors before parameter validation.
  • Update the transport specification and add normative fixtures plus mock-provider regression tests.

Closes #79.

Validation

  • cargo fmt --all --check — passed.
  • cargo test --workspace — passed (42 tests).
  • cargo clippy -p lpp-mock-provider --all-targets -- -D warnings — passed.
  • Release build and fixture validation — passed; 70/70 fixtures validated.
  • Focused runtime conformance for large integer IDs, pre-initialize requests, and repeated initialization — passed.
  • Full mock-provider conformance on Windows — 64/70 passed. Six existing project-loading cases fail because extended Windows paths are encoded as unsupported file URIs.
  • Workspace Clippy on Windows still stops at an existing unnecessary_lazy_evaluations warning in conformance/runner/src/session.rs; the changed mock-provider crate is clean.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T20:51:22.216142Z 67dac9c New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fca9055229

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread conformance/mock-provider/src/server.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03c814d633

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread conformance/mock-provider/src/server.rs
@Teakowa Teakowa closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mock provider: request-shape strictness — non-integer/string ids and missing params

2 participants