Skip to content

Mock provider: lpp/references conflates puzzle symbol with a same-named op #71

Closed

Description

@e54-bot

Audit finding M4 — verified live.

Problem

Occurrence lookup is keyed by op name only. Two wrong results:

  • Position on puzzle a while op a exists -> returns op a's declaration + solution references; the puzzle's own declaration is absent.
  • Position on puzzle solo with no same-named op -> locations: [] despite the position being on a valid symbol with includeDeclaration: true.

§14.2 requires the declaration to appear in locations when requested.

Acceptance criteria

  • references on a puzzle symbol returns the puzzle declaration (when includeDeclaration) and never an unrelated op's occurrences; op symbols behave as today.
  • Regression test covering the same-name case + green suite.

Activity

  1. added
    bugSomething isn't working
    ready-for-implementationContract settled; an Engineer can implement without inventing a decision
    on Oct 15, 2026
  2. e54-bot commented on Oct 15, 2026

    @e54-bot
    ContributorAuthor

    Fixed in #86 (commit 9fb5296).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingready-for-implementationContract settled; an Engineer can implement without inventing a decision

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions