Repository navigation
fix: reject unsafe schedule block counts before projection - #1
Draft
1932819331hy-debug wants to merge 2 commits into
Draft
1932819331hy-debug wants to merge 2 commits into
1932819331hy-debug wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject unsafe integer block heights/counts, unsafe schedule products and unsafe end-block sums. Shared validation runs before RPC. This prevents Number rounding from silently producing an inexact schedule while preserving fractional block-time rates and ordinary valid schedules. The latest follow-up removes duplicate checks already covered by assertScheduleShape and tests max-safe asynchronous boundaries.
Validation
Exact head 28751f5: 33 native tests pass on Node 24.19.0. Original new regression set had 7 failures before the fix and one positive control. Fresh independent delta review checked malformed-input rejection/precedence, no-RPC rejection, BigInt boundary oracles, ordinary-output equivalence and maximum-safe async completion/incompletion. No bounded correctness finding. Node 18/20/22 hosted CI remains unverified; opening as draft. No live RPC, credentials, paid service or dependency installation used.
AI-assisted implementation and independent AI-assisted local review. Independent correctness contribution, not a claim to complete the BNB grant wishlist.