Repository navigation
fix(release): tag the source commit instead of the release commit - #8367
Merged
noomorph merged 1 commit intoOct 20, 2026
Merged
Conversation
…commit The release commit lives only on ci/update-version-X, which is squash-merged (merge and rebase are disabled), so it never reaches master. Tagging it made the tag unreachable from master: previousTag stuck on the last old tag and release notes grew every release. The legacy scripts/release.js tagged the source commit, which is also what npm provenance points at. Also: docs example version, and Actions-created PRs do not trigger workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8366. Merge into that branch or cherry-pick; whichever is easier for you.
Problem
finalizetagsmanifest.releaseSha, the commit that exists only onci/update-version-X. This repo allows squash merge only, so that commit never reachesmaster. Consequences:git tag --merged <master>(index.cjs, plan) never sees the new tag, sopreviousTagstays on8.8.11forever. Release notes grow with every release and the/commits/{sha}/pullscalls grow with them.scripts/release.jstagged the source commit (8.8.11->92e3bf13, equal to npmgitHead), so this was a behaviour change.Change
target_commitishusemanifest.sourceSha. Publish already requirescontext.sha === sourceSha, so the tag now matches the npm provenance commit.releaseShais still used for the version branch and the version PR head.8.9.1(npmlatestis already8.9.0, so the docs would reject8.8.10); the line about approvals on the version PR now says thatGITHUB_TOKENevents do not start Actions workflows.Verification
node --test scripts/release/*.test.cjs: 28/28.