Skip to content

feat: Drive bulk selection mode - WPB-29376 - #5407

Merged
ohassine merged 5 commits into
developfrom
Drive-bulk-selection-mode
Oct 20, 2026
Merged

ohassine merged 5 commits into
developfrom
Drive-bulk-selection-mode

Conversation

@ohassine

@ohassine ohassine commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-29376


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Screen_recording_20261016_124715.mp4

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.00000% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.89%. Comparing base (65fb88a) to head (02ed07d).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...om/wire/android/feature/cells/ui/CellViewAction.kt 65.21% 8 Missing ⚠️
...om/wire/android/feature/cells/ui/OfflineListing.kt 77.14% 5 Missing and 3 partials ⚠️
...com/wire/android/feature/cells/ui/CellViewModel.kt 56.25% 2 Missing and 5 partials ⚠️
...wire/android/feature/cells/ui/CellBulkSelection.kt 83.33% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (74.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5407      +/-   ##
===========================================
+ Coverage    54.86%   54.89%   +0.03%     
===========================================
  Files          769      772       +3     
  Lines        27115    27161      +46     
  Branches      4502     4514      +12     
===========================================
+ Hits         14876    14911      +35     
- Misses       10821    10824       +3     
- Partials      1418     1426       +8     
Files with missing lines Coverage Δ
...ava/com/wire/android/feature/cells/ui/CellError.kt 100.00% <100.00%> (ø)
.../com/wire/android/feature/cells/ui/CellListItem.kt 0.00% <ø> (ø)
...wire/android/feature/cells/ui/CellScreenContent.kt 0.00% <ø> (ø)
...wire/android/feature/cells/ui/CellBulkSelection.kt 83.33% <83.33%> (ø)
...com/wire/android/feature/cells/ui/CellViewModel.kt 63.46% <56.25%> (-2.00%) ⬇️
...om/wire/android/feature/cells/ui/CellViewAction.kt 65.21% <65.21%> (ø)
...om/wire/android/feature/cells/ui/OfflineListing.kt 84.28% <77.14%> (-7.15%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65fb88a...02ed07d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

  356 files  ±0    356 suites  ±0   2m 35s ⏱️ -51s
2 949 tests +3  2 949 ✅ +3  0 💤 ±0  0 ❌ ±0 
2 955 runs  +3  2 955 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 02ed07d. ± Comparison against base commit 65fb88a.

This pull request removes 3 and adds 6 tests. Note that renamed tests count towards both.
com.wire.android.feature.meetings.ui.list.MeetingListViewModelTest ‑ givenEmptyList_whenLoadedRepeatedly_thenSyncOnlyOnce()
com.wire.android.feature.meetings.ui.list.MeetingListViewModelTest ‑ givenViewModel_whenNoEmptyListReported_thenDoNotSync()
com.wire.android.ui.calling.outgoing.OutgoingCallViewModelTest ‑ given a start call error, when user tries to start a call, call ring tone is not called()
com.wire.android.feature.meetings.ui.list.MeetingListViewModelTest ‑ givenInitialEmptyList_whenSyncing_thenShowInitialLoadingInsteadOfRefreshIndicator()
com.wire.android.feature.meetings.ui.list.MeetingListViewModelTest ‑ givenInitialNonEmptyList_whenLoaded_thenReadyWithoutSync()
com.wire.android.feature.meetings.ui.list.MeetingListViewModelTest ‑ givenRefreshRequestedRepeatedly_thenSyncEachTime()
com.wire.android.feature.meetings.ui.list.MeetingListViewModelTest ‑ givenViewModel_whenNoRefreshRequested_thenDoNotSync()
com.wire.android.ui.calling.outgoing.OutgoingCallViewModelTest ‑ [1] SyncFailure
com.wire.android.ui.calling.outgoing.OutgoingCallViewModelTest ‑ [2] StartFailure

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size Bot added size/L and removed size/M labels Oct 16, 2026
@ohassine
ohassine added this pull request to stack #5409 October 16, 2026 15:57
@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine
ohassine added this pull request to the merge queue Oct 20, 2026
Merged via the queue into develop with commit d6b12fc Oct 20, 2026
21 checks passed
@ohassine
ohassine deleted the Drive-bulk-selection-mode branch October 20, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants