Skip to content

fix: preserve modals opened during close cleanup - #569

Open
sean0407 wants to merge 1 commit into
wire-elements:mainfrom
sean0407:fix/wire-elements-modal-567-deferred-reset-state
Open

sean0407 wants to merge 1 commit into
wire-elements:mainfrom
sean0407:fix/wire-elements-modal-567-deferred-reset-state

Conversation

@sean0407

Copy link
Copy Markdown

Summary

close modal
  schedule reset after 300 ms
reopen before reset
  cancel stale reset and preserve the active modal

Addresses Bug 2 from #567 only. Bug 1's component-history race is outside this change. Adds a focused Node regression test and runs it in CI.

Evidence

  • Before: An isolated VM reproduced the stale close timer clearing activeComponent after a modal was reopened.
  • After: npm run test:js — 2 tests passed.

Merge Danger

Door: Two-way

Blast Radius: Low

Only modal close cleanup changes; reopening cancels the pending reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant