Skip to content

Document theme version file keys without the v prefix - #267

Open
matteotrubini wants to merge 1 commit into
wintercms:developfrom
matteotrubini:fix/theme-version-keys-v-prefix
Open

matteotrubini wants to merge 1 commit into
wintercms:developfrom
matteotrubini:fix/theme-version-keys-v-prefix

Conversation

@matteotrubini

Copy link
Copy Markdown
Contributor

Aligns the theme version.yaml example with what create:theme actually scaffolds — 1.0.1: 'Initial version', no v prefix.

Kept in a separate PR from the plugin version file fix because the two are not the same kind of problem. Unlike the plugin version file, a theme's is never read by the core: the Updates screen takes the theme version from the database record
(array_get($theme, 'version', …) in updates/_update_list.php), and the only PHP reference to the file is CreateTheme, which writes it. So no ordering bug is involved here — this is documentation alignment only.

Also renames the file's description in cms/themes.md from "Theme updates file" to "Theme version file", matching themes/development.md; "updates" is misleading because themes have no migrations or seeds.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 205828cb-60a6-4b17-9531-395abd5d998f

📥 Commits

Reviewing files that changed from the base of the PR and between 363910b and 33fb46b.

📒 Files selected for processing (2)
  • cms/themes.md
  • themes/development.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant