Repository navigation
Restore the @return types of the static analysis tests - #368
Merged
shadowhand merged 2 commits intoOct 2, 2026
Merged
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #360.
b5addd4 removed the
@returnannotations fromtests/static-analysis/, so the suite only checked the nativeiterable/stringtypes and no longer what Psalm infers from each assertion. This restores the 142 precise ones (the@return mixedlines are left out, the native types cover them) and regenerates thenon-return/variants, which now check the@psalm-assertnarrowing against them.Restoring them right away caught two things:
propertyExists()lost theclass-stringof its argument: unlikepropertyNotExists()andmethodExists(), it had no@template T as class-string|object. It now has the same template, andMixin.phpis regenerated.allNullOrThrows()declared@return iterable<Closure>for aniterable<Closure|null>input, a test mistake that the missing return check had hidden.Psalm is clean, and without the
propertyExists()change it reports 8 errors. PHPUnit is green,ProjectCodeTestincluded.