Repository navigation
Trust certifi's CA bundle on gRPC channels - #2218
Merged
Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes preserve credential overrides and cover the new behavior, with no identified blocking issues.
No open issues 🎉
What changed in this PR
Updates secure gRPC channels to trust certifi’s CA bundle, aligning default trust with REST connections.
Changes:
- Uses certifi roots while preserving explicit credentials and environment overrides.
- Adds a minimum certifi dependency and documents default trust behavior.
- Tests certifi defaults and environment overrides.
| File | Description |
|---|---|
| weaviate/connect/base.py | Loads certifi roots for default secure gRPC credentials. |
| weaviate/config.py | Documents default roots and environment overrides. |
| setup.cfg | Requires certifi 2026.10.19 or newer. |
| mock_tests/test_grpc_config.py | Tests default roots and environment override behavior. |
Review effort: Balanced
spiros-spiros
approved these changes
Oct 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2218 +/- ##
==========================================
+ Coverage 88.98% 89.02% +0.03%
==========================================
Files 308 309 +1
Lines 24396 24546 +150
==========================================
+ Hits 21709 21852 +143
- Misses 2687 2694 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tsmith023
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.