Repository navigation
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unexpected failure of one synchronous
BatchStreamcurrently closes and recreates the entire shared client connection. While that reconnect is in progress, queries on the same client fail withWeaviateClosedClientErrorand another active batch RPC terminates, even when the server is otherwise healthy.This change retries the failed RPC on the existing connection. It stops the old request iterator before handing over queued work, replays only sent requests without final results, and preserves the terminal stop when the caller has already left the batch context. Consecutive retry attempts are bounded, and explicit
client.close()interrupts recovery without reopening the client. Reference serialization uses a copy so replay does not mutate the cached reference. Recovery preservesskip_init_checksand the configured stream/init timeouts; it does not add a total recovery deadline.Related to #2139. The server's explicit
shutting_downreconnect policy remains unchanged. Startup and context-exit error propagation remain outside this change and are addressed separately in #2141; this PR does not claim to resolve the whole issue.Validation uses public SDK calls against real local HTTP/gRPC fixtures, including one or two failed streams; object and reference failures before ACK, after ACK, and after a final result; successive replacement failures; queued work ownership; context exit; retry exhaustion; and explicit close. The service records actual request counts, metadata, deadlines, and RPC termination. No Weaviate node crash, Docker cluster, or multi-node failover test has been run.
Validation on the final source: 540 unit tests passed, 1 skipped; the full local mock group had 86 passed and 1 failure, including all 17 new recovery cases passing. The failure was
mock_tests/test_auth.py::test_refresh: a rotated refresh token no longer matches the fixture's original-token handler. The same failure reproduced on pristine base671f0a5cwhen running the auth module (22 passed, 1 failed); that base test passed in isolation. No auth code or assertions were changed. Full Pyright and changed-file Ruff/format/flake8 checks passed. Independent real gRPC checks also verified that unavailable/denied Health services are not called when initialization checks are skipped.Developed with OpenAI Codex and independently reviewed and tested by a separate Codex agent.