Skip to content

Test dashboard status dialog content - #1252

Merged
dati18 merged 7 commits into
mainfrom
test-for-dialog
Nov 12, 2026
Merged

dati18 merged 7 commits into
mainfrom
test-for-dialog

Conversation

@dati18

@dati18 dati18 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Add unit tests for the Expired soon and Pending review dialog content.

Bug: T444602

@github-actions

Copy link
Copy Markdown

Deployment previews on netlify for branch refs/pull/1252/merge will be at the following locations (when build is done):

@dati18
dati18 added this pull request to stack #1253 November 11, 2026 15:32
@dati18
dati18 force-pushed the test-for-dialog branch 4 times, most recently from af4e7fc to 430e63e Compare November 12, 2026 12:15
outdooracorn
outdooracorn previously approved these changes Nov 12, 2026

@outdooracorn outdooracorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's update the PR description / commit message though 🙂

Base automatically changed from pending-review-popup to main November 12, 2026 14:22

@outdooracorn outdooracorn left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes we talked about in the call. If you're happy I'm happy 🙂

:shipit:

@dati18
dati18 merged commit 4ce38e8 into main Nov 12, 2026
7 checks passed
@dati18
dati18 deleted the test-for-dialog branch November 12, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants