Repository navigation
Conversation
addshore
force-pushed
the
svg-logo-for-mediawiki
branch
from
September 30, 2026 23:17
28c4891 to
2355a11
Compare
dati18
force-pushed
the
svg-logo-for-mediawiki
branch
from
October 15, 2026 14:34
2355a11 to
8bce080
Compare
dati18
force-pushed
the
svg-logo-for-mediawiki
branch
from
October 22, 2026 15:08
8bce080 to
6885e04
Compare
dati18
pushed a commit
to wbstack/api
that referenced
this pull request
Oct 23, 2026
Accept PNG and SVG logos up to 2 MiB. Sanitise SVGs before storage, check embedded CSS using Wikimedia's CSS parser, and generate PNG logo and favicon fallbacks with rsvg-convert (as svg support is less than png support). Basically all based on mediawikis own handling. Store the vector URL in wwLogoSvg and clear it when a PNG replaces the logo. Add regression coverage and document the processing requirements. The MW change wbstack/mediawiki#569 would be needed ahead of this. Bug: T356389
Expose the existing logo as both wgLogos['1x'] and wgLogos['icon'], including the default Wikibase Cloud logo fallback. This lets Vector 2022 display existing PNG uploads without changing the upload pipeline. Add a CI check for the default logo and document the mapping. I'm aware the phab task includes more requests as part of it, however this is likely the smallest single deployable thing in the right direction. Bug: T356389
The CI schema contains no saved Main Page, so its 404 makes curl --fail reject an otherwise valid logo response. Use Special:Version instead, keeping the HTTP success check and the exact logo assertion.
Map a new wwLogoSvg setting to wgLogos['svg'] and wgLogos['icon'] so Vector legacy, Vector 2022, and Timeless use the vector logo. API support for this setting will follow. Keep the existing logo fallback when no SVG is configured. Add an SVG fixture, a Vector 2022 regression check, and configuration documentation. Bug: T356389
Use Special:Version so the SVG logo check does not depend on saved Main Page content in the otherwise empty CI wiki database. Keep the HTTP success check and exact SVG URL assertion.
dati18
force-pushed
the
svg-logo-for-mediawiki
branch
from
October 27, 2026 12:20
6885e04 to
88b2d4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map a new wwLogoSvg setting to wgLogos['svg'] and wgLogos['icon']
so Vector legacy, Vector 2022, and Timeless use the vector logo.
API support for this setting will follow.
Keep the existing logo fallback when no SVG is configured. Add an SVG
fixture, a Vector 2022 regression check, and configuration documentation.
Bug: T356389
Stack created with GitHub Stacks CLI • Give Feedback 💬