Repository navigation
Fix missing wiki logos in Vector 2022 - #568
Merged
Merged
Conversation
dati18
force-pushed
the
fix-missing-logos-on-vecotr-2022
branch
from
October 15, 2026 14:34
6e6aebb to
27f55c1
Compare
dati18
force-pushed
the
fix-missing-logos-on-vecotr-2022
branch
from
October 22, 2026 15:08
27f55c1 to
99ee39b
Compare
dati18
approved these changes
Oct 26, 2026
Member
|
Moving some of the information from the PR description that @addshore's submitted to this comment as the description becomes the commit message when we squash and merge PRs.
|
Expose the existing logo as both wgLogos['1x'] and wgLogos['icon'], including the default Wikibase Cloud logo fallback. This lets Vector 2022 display existing PNG uploads without changing the upload pipeline. Add a CI check for the default logo and document the mapping. I'm aware the phab task includes more requests as part of it, however this is likely the smallest single deployable thing in the right direction. Bug: T356389
The CI schema contains no saved Main Page, so its 404 makes curl --fail reject an otherwise valid logo response. Use Special:Version instead, keeping the HTTP success check and the exact logo assertion.
dati18
force-pushed
the
fix-missing-logos-on-vecotr-2022
branch
from
October 27, 2026 12:20
99ee39b to
60e0140
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the existing logo as both
wgLogos['1x']andwgLogos['icon'], including the default Wikibase Cloud logo fallback. This lets Vector 2022 display existing PNG uploads without changing the upload pipeline.Add a CI check for the default logo and document the mapping.
Bug: T442140