Repository navigation
argocd-apps: trivy metrics - #233
Merged
Merged
Conversation
tarrow
requested changes
Oct 20, 2026
tarrow
left a comment
tarrow
left a comment
Contributor
There was a problem hiding this comment.
I really don't want to slow you down so feel free to push back but why are we hardcoding the values into the chart rather than taking them from somewhere in the deploy repo like we do for UI/API (see: https://github.com/wbstack/charts/blob/main/charts/argocd-apps/templates/wbaas-api.yaml#L19 ) ?
If we keep up this pattern every time we change a value we will need to release a new chart etc. and deploy with helmfile to get the new argocd-app-of-apps to update rather than argocd just noticing that that values have changed and automatically updating.
Perhaps this exceptionally makes sense.
tarrow
reviewed
Oct 20, 2026
Co-authored-by: Thomas Arrow <tarrow@users.noreply.github.com>
tarrow
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the service monitor of the trivy operator with a label that lets its metrics get ingested by prometheus
https://phabricator.wikimedia.org/T441413
Bug: T441413