Repository navigation
Conversation
…urations (fixes wavesplatform#3480) - Use monotonic System.nanoTime() to avoid clock skew and backwards time adjustments during NTP synchronization - Skip metric recording when elapsed time is non-positive, preventing Kamon out-of-range warnings - Bypass measurement when Kamon is disabled (Kamon.enabled() == false) to eliminate unnecessary CPU and object allocation overhead - Add comprehensive unit tests in TimerExtSpec
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes #3480
Problem Description
As reported in #3480, nodes frequently log warnings from
kamon.metric.Timerduring block application or mining:Root Cause
com.wavesplatform.metrics.TimerExt,startedTimer.stop()uses Kamon's clock, which relies on the system wall-clock time. When NTP synchronizes or shifts the system clock backwards during block execution, the calculated duration is negative.Solution
System.nanoTime()(which usesCLOCK_MONOTONICon Linux), guaranteeing that time never moves backwards even during NTP time synchronization.elapsed > 0) are recorded into Kamon metrics.Kamon.enabled()before measuring to executefdirectly with zero allocations and zero CPU overhead when metrics are disabled.TimerExtSpecverifyingmeasure,measureSuccessful, andmeasureOptionalbehavior.