Repository navigation
fix: keep image lightbox off video embed posters - #862
Conversation
YouTube click-to-play posters live in article content, so the image lightbox was treating them as expandable images. Clicking play opened the lightbox over the autoplaying iframe. Skip .video-embed images and mark posters with data-no-lightbox. Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR prevents the article image lightbox from enhancing YouTube video poster images while preserving normal article image lightbox behavior. The changed comments are targeted and accurate, no tests are changed, and the security/spec passes found no issues.
Concerns
- No blocking concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This branch was successfully deployed
2 participants
Summary
Stops the article image lightbox from intercepting VideoEmbed YouTube poster clicks. Clicking play on pages like
/factories/was expanding the poster image over the page while the video autoplayed underneath.Changes
src/components/ArticleImageLightbox.astro— exclude images inside.video-embedfrom lightbox enhancementsrc/components/VideoEmbed.astro— mark poster images withdata-no-lightboxsrc/styles/custom.css— note the VideoEmbed exclusion in the lightbox commentHow to test
/factories/Testing
Tested video embeds (both YouTube and Looms) in the following pages:
• /factories/
• /guides/getting-started/welcome-to-warp/
• /code/code-review
• /agents/local-agents/generate
• /agents/capabilities/skills
• /platform/viewing-cloud-agent-runs
• /knowledge-and-collaboration/warp-drive/workflows
• /agents/local-agents/session-sharing
Co-Authored-By: Warp agent@warp.dev