Repository navigation
Require patched PHP and disable session upload progress - #484
Open
RobertDWhite wants to merge 1 commit into
Open
RobertDWhite wants to merge 1 commit into
RobertDWhite wants to merge 1 commit into
Conversation
Member
|
Hello @RobertDWhite, I don't see the value of adding a build-time requirement of a minimal php version like this as we rely on the distribution for the packages. Regarding the third PHP vulnerability yet to be patched and tracked under CVE-2026-115560, we don't default the serialize handler to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current master Dockerfile installs PHP 8.4 without a security floor, and session upload progress remains enabled. This adds a build-time requirement for PHP 8.4.27 or newer and disables session upload progress in the PHP 8.4 conf.d directory, following PHP's October 23 advisory. The existing database test matrix now checks both properties in the running container.
Related to #480. This complements the pending patched-image release; it does not resolve Wallabag's broader PHP compatibility work or replace a new published image. It does not change the release workflow discussed in #481.
Reference: https://www.php.net/archive/2026.php (October 21 critical fixes and October 23 follow-up advisory).
Validation: Python test syntax and git diff checks pass. Full image builds and database integration tests require CI; they have not been run locally.