Repository navigation
docs: record where the plugin page's content comes from - #148
Merged
Merged
Conversation
The page renders `meta.detail` from `locale/<language>.json`, falling back to the whole README — which is why this package's page carried 461 lines of engineering notes until the previous commit. A maintainer needs that fact in the map, not only in the test that enforces it, because the next person to wonder why the page looks like that will read the map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin page renders
meta.detailfromlocale/<language>.json, falling back to the whole README — which is why this package's page carried 461 lines of engineering notes until #146.A maintainer needs that fact in the repo map, not only in the test that enforces it, because the next person to wonder why the page looks like that will read the map first.
One entry, pointing at
docs/detail.md, the hero image's shipping requirement, andtest/plugin-detail.test.ts.