Harden plugin test workflow slug handling - #6
Open
marktopper wants to merge 1 commit into
Open
marktopper wants to merge 1 commit into
marktopper wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #4. Keep changed plugin slugs out of shell command interpolation by passing them through an environment variable and parsing that value inside the Node runner. This prevents shell metacharacters in PR-controlled path components from being interpreted as commands.
The runner splits the environment value on whitespace, preserving changed-plugin selection behavior (including testing all plugins when the value is empty).
Verification
npm run validatenode --check scripts/test.mjsgit diff --checkThe full PHPUnit suite could not be run because the clean Vito 4.x checkout has no Composer dependencies installed.