Repository navigation
fix: skip blank gitignore lines when checking lockfiles - #613
Open
vibgrate-team wants to merge 1 commit into
Open
vibgrate-team wants to merge 1 commit into
vibgrate-team wants to merge 1 commit into
Conversation
A carriage return that is not part of CRLF was compiled as a pattern that matches every path, so vg build and vg scan skipped lockfiles. Blank and whitespace-only ignore lines are now dropped, matching source discovery. Closes #279 Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Empty and whitespace-only ignore lines were already dropped while
vg buildandvg scandiscovered source. The lockfile check still passed.gitignorestraight to the ignore matcher. A carriage return that is not part of a CRLF pair — a file that contains only\r, or a real rule followed by a bare\r— compiled to a pattern that matches every path, so lockfiles were skipped and a truncated lockfile did not fail the command.Those lines are now dropped with the same rule source discovery uses. A real pattern next to a blank one still applies. Empty and whitespace-only
--excludevalues stay skipped and are called out in the command help and inDOCS.md.Related issues
Closes #279
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time, randomness, or filesystem-order dependence)git commit -s, DCO)Notes for reviewers
test/blank-exclude.test.tscovers a carriage-return-only.gitignoreand a real rule followed by a bare CR, for both source discovery and the lockfile check.