Repository navigation
fix(docker): substitute ARG defaults in FROM image refs - #603
Open
vibgrate-team wants to merge 1 commit into
Open
vibgrate-team wants to merge 1 commit into
vibgrate-team wants to merge 1 commit into
Conversation
Dockerfile ARG defaults are expanded before an image row is recorded, so
FROM ${BASE} with a nested default such as node:${NODE_VERSION}-alpine
becomes library/node at 20-alpine. A FROM that still names a variable with
no default is skipped instead of emitting a literal ${...} image.
Fixes #577
Signed-off-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dockerfiles that parameterise a base image with
ARGdefaults were recorded as a literal image name such aslibrary/${BASE}with unknown drift.FROMnow substitutes$NAMEand${NAME}fromARG name=defaultvalues that appear earlier in the file, including a default that itself references an earlier argument.That file yields one
library/noderow at20-alpine.FROM $UNSETwith no default yields no row. Unresolved${...}text is never written into an image name or tag.Related issues
Fixes #577
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time, randomness, or filesystem-order dependence)git commit -s, DCO)Notes for reviewers
No public docs describe Dockerfile
FROMparsing, so none were changed. A variable with no default drops thatFROMrather than inventing an image. Defaults are expanded when theARGis seen, so a laterARGdoes not rewrite an earlier default that already used it.