Repository navigation
fix(helm): keep aliased subchart versions distinct - #601
Open
vibgrate-team wants to merge 1 commit into
Open
vibgrate-team wants to merge 1 commit into
vibgrate-team wants to merge 1 commit into
Conversation
Chart.yaml alias was ignored and Chart.lock versions were stored by chart name, so two dependencies on the same chart shared whichever lock entry was read last. Record alias on the row, keep the chart name for registry lookups, and pair each lock entry by name and version. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Helm allows one chart to depend on the same subchart twice under different
alias:names, often at different versions.Chart.yamlparsing droppedalias, andChart.lockversions were stored by chart name only, so both rows received whichever lock entry was read last and looked the same in scan output.Each dependency now keeps its alias on the row (shown as
redis (cache)in findings and text output). The package name stays the chart name (redis) so registry lookups are unchanged. Lock entries, which have no alias, are paired by chart name and version, so each aliased row gets its own resolved version. A chart that depends on a name only once still uses the lock entry for that name, as before.Related issues
Fixes #582
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time,randomness, or filesystem-order dependence)
git commit -s, DCO)Notes for reviewers
Unaliased charts do not gain an
aliasfield. When the same chart name is declared more than once, overlapping version constraints are assigned to distinct lock entries in chart order, and a repository URL is used as a tie-break when both sides set one.