Repository navigation
fix(docker): scan Dockerfile variants and every Compose file - #600
Open
vibgrate-team wants to merge 1 commit into
Open
vibgrate-team wants to merge 1 commit into
vibgrate-team wants to merge 1 commit into
Conversation
Recognise Containerfile, Dockerfile.<suffix>, and <name>.Dockerfile, and parse every Compose file in a directory, including overrides. Image rows stay deduplicated on name and tag. Fixes #580 Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vg scanonly treated five exact filenames as Docker manifests (Dockerfile,docker-compose.yml,docker-compose.yaml,compose.yml,compose.yaml), and it stopped after the first Compose file in a directory. Common layouts were skipped.The scanner now recognises:
Dockerfile,Containerfile,Dockerfile.<suffix>(Dockerfile.prod), and<name>.Dockerfile(api.Dockerfile)docker-compose.yml/.yaml,compose.yml/.yaml, and overridesdocker-compose.<name>.yml/.yamlandcompose.<name>.yml/.yamlEvery matching file in a directory is parsed. Image rows stay deduplicated on name and tag, so the same image and tag in two files is one row and two tags stay two rows. The recognised names are listed in
DOCS.md.Related issues
Fixes #580
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time, randomness, or filesystem-order dependence)git commit -s, DCO)Notes for reviewers
Project directories are sorted by path before they are scanned, so a tree with several Docker projects reports them in a stable order. Names are matched with the capitalisation above (
Containerfile, notcontainerfile).