Repository navigation
fix(docker): keep registry hosts on non-Hub image names - #599
Open
vibgrate-team wants to merge 1 commit into
Open
vibgrate-team wants to merge 1 commit into
vibgrate-team wants to merge 1 commit into
Conversation
Dockerfile and Compose rows dropped the registry, so ghcr.io, mcr.microsoft.com, and quay.io images were stored as Docker Hub names and compared with Hub tags. Hub aliases still record as library/<image> or <namespace>/<image>. Other registries keep their host and are not sent to the Docker Hub tag API. Fixes #578 Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DockerfileFROMlines and Composeimage:lines dropped the registry host when they built a dependency row.ghcr.io/acme/api:1.4.0was stored asacme/api,mcr.microsoft.com/dotnet/sdk:8.0asdotnet/sdk, andquay.io/prometheus/node-exporter:v1.8.0asprometheus/node-exporter, and each name was then compared with Docker Hub.The recorded name now keeps the registry for any host that is not Docker Hub. Docker Hub images stay
library/<image>or<namespace>/<image>, includingdocker.io,index.docker.io, andregistry-1.docker.io. The tag lookup calls Docker Hub only for those names. Other registries stayunknownunless a package-version manifest already lists that exact name.Related issues
Fixes #578
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time, randomness, or filesystem-order dependence)git commit -s, DCO)Notes for reviewers
nginx:1.27andbitnami/redis:7.4still record aslibrary/nginxandbitnami/redisand still go to the Docker Hub tag API. Short tags such as1.27are not strict semver, so their drift staysunknownwhilelatestStableis filled from Hub, which is the same comparison as before.