Repository navigation
Update libvalinet to fix Unicode PDB paths - #5228
Open
HosisoraLing wants to merge 1 commit into
Open
HosisoraLing wants to merge 1 commit into
HosisoraLing wants to merge 1 commit into
Conversation
|
was this done using ai? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ExplorerPatcher is configured to use the Windows 10 taskbar, signing in to Windows can leave the user with no desktop and no taskbar. Manually starting
explorer.exethen makes the desktop/taskbar appear and disappear repeatedly as the shell exits.The affected machine runs Windows 11 25H2 x64 (26200.9457), ExplorerPatcher 26100.9711.71.1, and the UTF-8 active code page (65001), with Chinese characters in the Windows username. The PDB cache is consequently under a non-ASCII user-profile path.
In this environment, libvalinet's ANSI
SymGetModuleInfo64()call returned a truncatedLoadedPdbName: a path ending inExplorerPatcher\explorer.pdbwas reported as ending inExplorerPatcher\explor.fopen_s()fails to open that path, and the assertion increate_pools()callsexit(-1), terminating the Explorer shell. This is the confirmed failure path; the report does not imply that every Chinese username triggers it.Update
libs/libvalinetfrom34ffcd4to797404f, which includes the Unicode PDB-path fix merged in valinet/libvalinet#5. The fix usesIMAGEHLP_MODULEW64,SymGetModuleInfoW64()and_wfopen_s()to preserve the path through the file open.Validation: the x64 DLL built successfully. A locally packaged build using this exact dependency update restored the Windows 10 taskbar on the affected machine, and the user confirmed that the desktop and taskbar also started normally after a real reboot. Read-only checks after that reboot confirmed that the repaired DLL and Windows 10 taskbar component were loaded, with the EP crash counter at zero.
This PR changes only the libvalinet submodule reference. It contains no test fixtures, diagnostic scripts, binaries, or machine-specific settings.