Skip to content

Update libvalinet to fix Unicode PDB paths - #5228

Open
HosisoraLing wants to merge 1 commit into
valinet:masterfrom
HosisoraLing:fix/pdb-unicode-paths
Open

HosisoraLing wants to merge 1 commit into
valinet:masterfrom
HosisoraLing:fix/pdb-unicode-paths

Conversation

@HosisoraLing

Copy link
Copy Markdown

When ExplorerPatcher is configured to use the Windows 10 taskbar, signing in to Windows can leave the user with no desktop and no taskbar. Manually starting explorer.exe then makes the desktop/taskbar appear and disappear repeatedly as the shell exits.

The affected machine runs Windows 11 25H2 x64 (26200.9457), ExplorerPatcher 26100.9711.71.1, and the UTF-8 active code page (65001), with Chinese characters in the Windows username. The PDB cache is consequently under a non-ASCII user-profile path.

In this environment, libvalinet's ANSI SymGetModuleInfo64() call returned a truncated LoadedPdbName: a path ending in ExplorerPatcher\explorer.pdb was reported as ending in ExplorerPatcher\explor. fopen_s() fails to open that path, and the assertion in create_pools() calls exit(-1), terminating the Explorer shell. This is the confirmed failure path; the report does not imply that every Chinese username triggers it.

Update libs/libvalinet from 34ffcd4 to 797404f, which includes the Unicode PDB-path fix merged in valinet/libvalinet#5. The fix uses IMAGEHLP_MODULEW64, SymGetModuleInfoW64() and _wfopen_s() to preserve the path through the file open.

Validation: the x64 DLL built successfully. A locally packaged build using this exact dependency update restored the Windows 10 taskbar on the affected machine, and the user confirmed that the desktop and taskbar also started normally after a real reboot. Read-only checks after that reboot confirmed that the repaired DLL and Windows 10 taskbar component were loaded, with the EP crash counter at zero.

This PR changes only the libvalinet submodule reference. It contains no test fixtures, diagnostic scripts, binaries, or machine-specific settings.

@pyrates999

Copy link
Copy Markdown

was this done using ai?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants