Repository navigation
fix: fetch configured scrypt tag in shallow builds - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch the configured scrypt release directly with
git clone --depth 1 --branch, instead of shallow-cloning the default branch and resetting to an older tag absent from that clone. The unchanged2.0.1version currently fails every PHP/architecture build withunknown revision, blocking publication of the CA security update.Validation: reproduced the failure in CI run 39587242503; cloned with the corrected command and confirmed
git describe --tags --exact-matchreturns2.0.1;git diff --check. No dependency version change.