Repository navigation
Fix issue that logical location resolver would accidentally fail on recursive calls - #2928
Merged
Merged
Conversation
sungshik
force-pushed
the
fix-logical-location-resolver
branch
from
October 12, 2026 09:46
7eb6d6b to
65a160c
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2928 +/- ##
=======================================
- Coverage 45% 45% -1%
+ Complexity 6815 6808 -7
=======================================
Files 844 844
Lines 68837 68842 +5
Branches 10039 10041 +2
=======================================
- Hits 31435 31423 -12
- Misses 35007 35026 +19
+ Partials 2395 2393 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sungshik
marked this pull request as ready for review
October 12, 2026 10:21
DavyLandman
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR fixes an issue with the logical location resolver, which causes usethesource/rascal-language-servers#1229 to fail in GHA (update to RC17).
The problem is a regression bug introduced in #2901. Before #2901, the following could happen to resolve a logical location:
null), then the result of step 1 was returned.After #2901, however, the following would happen in the same scenario:
null, even if step 1 succeeded).This PR restores the version of step 3 from before #2901.