Build tooling work, commits C85-C94: comment rules, one die, and the formatter in the lint gate - #216
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the tooling review's later phases. It states the tooling's comments as rules, shares one
dieinlib/cli.mjs, and adds a formatter check to the lint gate.scripts/,builder/,lib/,book/andwisdom/now state their rules. The incidents behind them stay in the WIP notes and in history.scripts/survey_tooling.mjsis re-run against its baseline. The Landed entries for Phases 5 and 6 inbuilder/PLAN-TOOLING-REVIEW.mdare cut to what later work needs.die. They now share the one inlib/cli.mjs.check_lintruns Biome's formatter check as well as its linter. The style rules are set to the majority style already in the tree, and the pre-commit hook runs the same check on staged scripts. Dense literal tables keep their hand layout underbiome-ignore formatcomments.scripts/,builder/,lib/,book/,wisdom/andtest/. This is most of the 186 files in the range, and none of those edits changes behaviour..git-blame-ignore-revslists the commit, sogit blameskips it once a clone setsblame.ignoreRevsFile.test/search.test.mjsreadsKIND_WORDSas a literal rather than as JSON, so the formatter can lay the table out.