Build tooling work, commits C76-C84: smaller builder and harness modules, two render and date fixes - #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the tooling review: it splits three large builder and harness files into modules and fixes two small defects that the splits exposed.
test/render.test.mjs(new) covers it. The toc marker's comment is corrected, and the C76 split was not taken.builder/gantt.mjs(new) holds the Gantt sections and their grouping, moved out oftbdocs.mjs.builder/strftime.mjs(new) holds the date formatter, moved out oftemplate.mjs. Its%jnow gives the calendar day in three digits. No build callsformatDate, because no page setslast_modified_date.test/strftime.test.mjs(new) covers it.book.mjs's image-path helpers move next to their one caller.scripts/lib/example-batches.mjs(new) holdscheck_examples' batching, canaries and fence classifier, andcheck_examples.mjsshrinks by about 1,100 lines.test/example-batches.test.mjs(new) tests it with no IDE.tb-ide.mjssheds its console reading (tb-ide-console.mjs) and its add-in introspection (tb-ide-addins.mjs).launchIde's refusal now names the process that holds the port.node --testfiles. They are also added to the shared CI action, andcheck_gate_listsis updated to match.builder/PLAN-TOOLING-REVIEW.mdare cut to what later work needs, and the WIP notes are updated.