Build tooling work, commits C52-C65, C65a, C65b: shared builder and harness modules - #212
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the command-line migration with
tbdocs, folds the builder's and the harness's duplicated helpers into shared modules, and removes a pdf-lib shim that patched a function pdf-lib never calls.tbdocsnow parses throughlib/cli.mjs(builder/command-line.mjs), so every tool in the repository does. Its usage errors keep exit code 4, outside the link-check bitmask.check_cligrows to 254 checks (49 probes, 205 recorded cases, 30 of them fortbdocs).builder/url.mjsholds the URL helpers the build andcrawl_checkused to write separately.builder/escape.mjsholds the HTML, XML and RegExp escapers.builder/code-guard.mjsholds the one<code>/<pre>guard,replaceOutsideCode.builder/baseline.mjsis the one drift guard behind the page-count and symbol-index baselines.paths.mjs,nav.mjsandvendor-assets.mjs.cpu-worker.mjs's three timed task paths share one runner.<code>and<pre>, throughreplaceOutsideCode.check_code_regionshas probes for each.tbdocs's exit bits are named constants (EXIT_FAILED,EXIT_INTEGRITY,EXIT_COMMAND_LINE), set in one place and shared withserve.mjs.check_regex_safetyfollows relative imports, so a regex built from an imported escaper or constant is still analysed. The newcheck_twin_parsersgate (121 probes) checks that the three scanners of twinBASIC source share one modifier list and one declaration classifier (scripts/lib/twin-declarations.mjs), and that they read the shapes each once misread.test.batis thirteen steps, and the shared CI action runs the new gate.logicalLinesfor twinBASIC source.scripts/lib/tb-click.mjs, which the build icon now goes through too.COMPILE_TIMEOUT, used at eight sites.scenario()frame (test/addin/scenario.mjs), and six of them read the Debug Console through onelinesSince. A lane now fails when closing it finds a compiler crash or a javascript dialog. Before, the close ran in anafterhook, andnode --testexits 0 when anafterhook throws, so such a lane passed.fast-inflate.mjsis deleted. It replacedpako.inflate, which pdf-lib 1.17.1 never calls: a load decodes the cross-reference and object streams through pdf-lib's ownFlateStream.pakois no longer a direct dependency (pdf-lib still installs 1.0.11 for itself). Two renders of the samebook.html, before and after, have the same 2,298 pages, the same outline and the same size, and differ only in their/CreationDateand/ModDate.build.bat,check.bat,test.batand lint ran clean at each commit, andcompare_treesshowed each refactor leaving the built site unchanged (recorded inbuilder/PLAN-TOOLING-REVIEW.md). On BETA 987,examples.batcompiles 1,134 of 1,134 samples andaddin-test.batpasses 10 of 10 lanes.