Repository navigation
Don't save default settings over ones that failed to load - #636
Merged
Merged
Conversation
When the invoicing preferences or the currency settings failed to load, Settings showed the built-in defaults as if they were the user's own: EUR and a 1% conversion fee, the daily number scheme, English, the default template and EN16931. Pressing Save then wrote those defaults over the real settings. A profile that failed to load came back as an empty profile, which Save would write over the real one as well. A failed load now shows an error with Retry in place of the form, and Save stays off until the settings have loaded. The core reports a profile it cannot read as an error instead of an empty one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the invoicing preferences or the currency settings failed to load, Settings showed the built-in defaults as if they were the user's own: EUR, a 1% fee, daily numbering, English, EN16931. Save then wrote them over the real settings. A profile that failed to load came back empty, ready to be saved over the real one.
馃 Generated with Claude Code