Repository navigation
Conversation
Document import saved contracts without the contract form's checks, so a document's "19" became a 1900% VAT rate. Fields the document left open took model defaults (a 31-day term, an hourly unit, a monthly cycle) while the review showed them blank, and links to entities left out of the import were dropped without a word. The commit now runs the contract form's validators and names the contract it refuses. An unstated payment term stays empty, and the fields a contract's type needs are required in the review. A link to an entity that is not imported, or to a record that is gone, is refused by name. Without the model's 31-day default, the contract form can also save a contract without a payment term. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
clstaudt
added this pull request to stack #631
October 18, 2026 20:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document import saved contracts unchecked: a document's "19" became a 1900% VAT rate, fields the document didn't state silently took model defaults, and links to entities rejected in the review were dropped.
馃 Generated with Claude Code