Skip to content

Say which amounts totals leave out for lack of an exchange rate - #627

Open
clstaudt wants to merge 1 commit into
no-tax-estimate-without-year-datafrom
say-which-amounts-lack-a-rate
Open

clstaudt wants to merge 1 commit into
no-tax-estimate-without-year-datafrom
say-which-amounts-lack-a-rate

Conversation

@clstaudt

@clstaudt clstaudt commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Amounts whose exchange rate couldn't be resolved, e.g. offline, were silently left out of every total.

  • Totals: each total lists what it left out. The KPIs, revenue chart, cash flow, goals, Tax view and Salary show one line: "Leaves out 2 amounts without an exchange rate: …".
  • Retry: a failed rate lookup is retried after a minute, instead of staying failed until restart.
  • Tax: without a rate into the tax currency, income is no longer taxed 1:1; the estimate says which rate is missing.

🤖 Generated with Claude Code

@clstaudt
clstaudt added this pull request to stack #620 October 18, 2026 20:23
When the exchange rate for a foreign-currency invoice, expense or contract
could not be found, every total left the amount out without a word: the
dashboard, the revenue chart, the cash flow, the goals, the tax view and
the salary all came out lower, and nothing said why. A failed lookup was
also remembered for the whole session, so the amounts stayed out after
the network came back.

Leaving them out is still right, but each total now names what it left
out, and the page shows one line such as "Leaves out 1 amount without an
exchange rate: Expense Software (USD)." A failed lookup is tried again
after a minute. Income in another currency than the tax rules' is no
longer taxed as if one were worth the other when the rate is missing: the
tax view then shows no tax and says which rate is missing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@clstaudt
clstaudt force-pushed the say-which-amounts-lack-a-rate branch from b082bd7 to abadb4f Compare October 20, 2026 13:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant