Repository navigation
Conversation
clstaudt
added this pull request to stack #620
October 18, 2026 20:23
Tax rules are kept in one file per year. For a year without its own file, before the first or after the last, the engine took the nearest year's rules, so the tax view estimated that year's income tax with rules that were never in force for it and showed it like any other estimate. A year without its own rules now has none: the tax view, the salary and the cash flow show no tax for it and say so, for example "No tax rules for Germany in 2023." A country's currency no longer depends on the year, so amounts are still converted into it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
clstaudt
force-pushed
the
no-tax-estimate-without-year-data
branch
from
October 20, 2026 13:48
917cbe8 to
b0c2319
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A year without its own tax rules was estimated with the nearest year's rules (#622 only labelled that). Now such a year has no estimate: "No tax rules for Germany in 2023." A country's currency no longer depends on the year, so conversions still work.
From 1 January of a year whose rules are missing, every tax estimate waits for them, and so do the tests that use the current year.
馃 Generated with Claude Code