Skip to content

Don't cancel a deposit that a final invoice settles - #605

Open
clstaudt wants to merge 1 commit into
one-final-invoice-per-projectfrom
keep-settled-deposits
Open

clstaudt wants to merge 1 commit into
one-final-invoice-per-projectfrom
keep-settled-deposits

Conversation

@clstaudt

@clstaudt clstaudt commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

A deposit cancelled after its final invoice stayed among the final's deductions. The final invoice, its PDF and its e-invoice then asked for too little, revenue lost the deposit, and paying the final marked the cancelled deposit paid.

  • Cancelling such a deposit is refused: "Cancel the final invoice first, then the deposit." Restoring a deposit stays possible.
  • The invoice view now shows why a status change was refused; before, every refusal was silently ignored. Unexpected errors point to the application log instead of showing raw exception text.

馃 Generated with Claude Code

@clstaudt
clstaudt added this pull request to stack #608 October 18, 2026 12:11
@clstaudt
clstaudt force-pushed the keep-settled-deposits branch from f4bc13e to 9ff5801 Compare October 18, 2026 20:21
Cancelling a deposit after its final invoice existed left it among the
deposits the final invoice deducts. The final invoice, its PDF and its
e-invoice then asked the client for too little, revenue lost the
deposit's amount, and paying the final invoice marked the cancelled
deposit paid.

Cancelling such a deposit is now refused with a message that says to
cancel the final invoice first. Restoring a cancelled deposit stays
possible, and paying a final invoice leaves cancelled deposits unpaid.
The invoice view now shows why a status change was refused instead of
silently ignoring it, and an unexpected failure says that the details
are in the application log rather than showing the raw error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@clstaudt
clstaudt force-pushed the keep-settled-deposits branch from 9ff5801 to 66355a6 Compare October 20, 2026 13:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant