Repository navigation
Conversation
clstaudt
added this pull request to stack #608
October 18, 2026 12:11
clstaudt
force-pushed
the
one-final-invoice-per-project
branch
from
October 18, 2026 20:21
eb6476d to
d9d0e39
Compare
A second final invoice for a project went through, because the check for an existing settlement relied on a data-source method that was never implemented. The new final invoice took over the deposits, so the first one's balance jumped back to the full price, and revenue counted the contract twice. A project now knows it is settled while it has a final invoice that is not cancelled. Creating another final invoice is refused with a message that names the existing one and says to cancel it first, also on fixed-price contracts without deposits. The invoice dialog no longer offers Final for a settled project. An invoice now carries only the id and title of its project, so serialising it does not need the project's invoices. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
clstaudt
force-pushed
the
one-final-invoice-per-project
branch
from
October 20, 2026 13:25
d9d0e39 to
10e7285
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A second final invoice for a project went through: the check for an existing settlement called a data-source method that was never implemented. The new final invoice took over the deposits, so the first one's balance jumped back to the full price, and revenue counted the contract twice.
Project.final_invoiceandProject.is_settled. A cancelled final invoice settles nothing.{id, title}, which is all the UI reads.馃 Generated with Claude Code