Repository navigation
feat(semconv-ai): standardize gen_ai.security.threat.* event and attribute names (#4096) - #4491
FinalSunFlower wants to merge 4 commits into
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly and concisely describes the main change: adding standardized gen_ai.security.threat.* event and attribute names, including the new semantic convention definitions. |
| Linked Issues check | ✅ Passed | The changes satisfy the coding requirements in issue #4096. Events adds gen_ai.security.threat.detected. EventAttributes adds all six required attributes. The severity enum contains low, `medi… |
| Out of Scope Changes check | ✅ Passed | The changes stay within issue #4096. The enums, documentation, and tests support the additive event and attribute schema. No dashboards, evaluator helpers, or unrelated implementation are shown. |
| Docstring Coverage | ✅ Passed | Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
Comment @coderabbitai help to get the list of available commands.
|
Hi team, just bumping this PR when you have a moment. The CI workflows just need a quick approval to kick off the test suite. Happy to make any adjustments if needed! |
|
Hi team! Just a quick bump on this. It looks like the CI workflows are waiting for a maintainer's approval to run. Could someone please take a look and approve the run when you have a chance? Thank you!" |
Summary
gen_ai.security.threat.detectedevent constantTesting
python -m pytest packages/opentelemetry-semantic-conventions-ai/tests -qpython -m ruff check packages/opentelemetry-semantic-conventions-ai/opentelemetry packages/opentelemetry-semantic-conventions-ai/testsCloses #4096
Summary by CodeRabbit
New Features
Tests