Repository navigation
Testing new pm - #163
Open
ofw24 wants to merge 11 commits into
Open
Testing new pm#163ofw24 wants to merge 11 commits into
ofw24 wants to merge 11 commits into
Conversation
The button shows while a Type is selected and calls remove_type on the server; a refused removal shows the error on the New type strip's note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… pane An own entry's unit cell is a line edit; Return calls set_type_parameter_unit, which propagates the unit to every Instance, then refreshes the GUI so the parameter tree shows the new units. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es pane The button sits next to Show; after confirmation it removes every parameter under the Instance, and the emptied groups go with them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… edits - server: the zmq poller reports the wakeup socketpair by its file descriptor, so the old 'socket in socks' check never matched, the pipe was never drained, and the request loop spun at 100% CPU after the first request. - GUI: a burst of Broadcasts (an Instance added or removed) emits structureChanged once, after 50 ms of quiet, instead of rebuilding the tints and Types pane once per parameter. - GUI: the instance delete button calls the Server directly and refreshes the proxy once, instead of refetching the whole blueprint per parameter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
update() only added parameters it did not have yet, so a unit the Server changed in place (a Type's unit edit propagates to its Instances) stayed stale on the proxy; the Parameter Manager GUI then saw the Instance's units disagree with its Type and stopped counting it as an Instance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e Lock re-target - The Types tab's entries pane reads parameter | unit | default | global | locked to global. The global column shows and sets the value every locked Instance follows: the Type Lock's Target, or the entry's _globals.<type>.<path> parameter while unlocked. Default and global boxes are narrower. - ParameterManager.ensure_global_targets() creates the Globals parameter of every Type entry that has none; the GUI calls it so every entry has a global value to edit. set_type_parameter_unit also updates the entry's Globals parameter, so a later Type Lock does not hit a unit conflict. - Remove the Type Lock re-target button, its arm-strip path and the rank_lock_targets arm_rel option only it used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…obal values - Removing a Type, or one of its entries, also removes its Globals parameters (_globals.<type> or _globals.<type>.<path>). The Server drops every Lock on a removed parameter first, so the Instance parameters locked to them go back to their own values. Instance, Type and entry removal share one helper that calls the Server directly and refreshes the proxy once. - The global value cell gets the parameter rows' set button: an edit turns it orange, Return or the button sets the value and turns it back. An uncommitted edit survives pane rebuilds and incoming values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e on edit The default editor in the Types tab gets the parameter rows' set button: an edit turns it orange, Return or the button sets the default and the next rebuild shows it plain again. An uncommitted edit survives pane rebuilds. Also apply ruff format to the two GUI files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding gui buttons, making things faster, cleaning up ui