[davecheney]

No description provided.

[deadprogram]

Thanks for this. A few things:

• Please use internal/pin for the CS, DC, RST, and BUSY pins instead of defining OutputPin and InputPin here. The ili9325 driver is an example.
• Please add doc comments for the exported Config, Device, Width, Height, and DefaultBusyTimeout.
• The slideshow tests in examples/ do not run in CI, since the Makefile excludes the examples directory. Could you either drop them or move the parsing into somewhere that gets tested?

[davecheney]

Thanks for this. A few things:

• Please use internal/pin for the CS, DC, RST, and BUSY pins instead of defining OutputPin and InputPin here. The ili9325 driver is an example.

Done

• Please add doc comments for the exported Config, Device, Width, Height, and DefaultBusyTimeout.

Done

• The slideshow tests in examples/ do not run in CI, since the Makefile excludes the examples directory. Could you either drop them or move the parsing into somewhere that gets tested?

Removed

Thanks @deadprogram PTAL

[deadprogram]

Thanks for the addition @davecheney and the requested changes. Now merging.