Repository navigation
ws2812: send full brightness as 0xff - #934
Merged
Merged
Conversation
applyBrightness scaled by brightness/256, so at the default brightness of 255 a 0xff color was sent as 0xfe. Scale by (brightness+1)/256 instead, and add tests for the arithmetic. applyBrightness moves to its own file, and the files that import machine build only with TinyGo, so go test can run the tests. The package doc and go:generate lines move to doc.go, so go generate still works. Checked on a Teensy 3.6 with a logic analyser: the colour bytes now decode as 0xff.
deadprogram
approved these changes
Oct 27, 2026
deadprogram
left a comment
deadprogram
left a comment
Member
There was a problem hiding this comment.
Great work @davecheney thank you very much! Now merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applyBrightness scaled by brightness/256, so at the default brightness of 255 a 0xff color was sent as 0xfe. Scale by (brightness+1)/256 instead, and add tests for the arithmetic.
applyBrightness moves to its own file, and the files that import machine build only with TinyGo, so go test can run the tests. The package doc and go:generate lines move to doc.go, so go generate still works.
Checked on a Teensy 3.6 with a logic analyser: the colour bytes now decode as 0xff.
The trace shows one blue LED before and after the fix. Before, the last bit of the blue byte is a 0.