Repository navigation
web: CodeMirror source editor in place of the textarea - #10
Merged
Merged
Conversation
The source box is now a CodeMirror editor with line numbers, history and standard editing keys, themed from the page's CSS tokens. It keeps the same interface: the value is controlled, and choosing an example replaces the document. The smoke test types into it, and checks that choosing an example updates it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the source textarea with a CodeMirror 6 editor (line numbers, undo history, standard editing keys) from the Phase 7 plan.
SourceEditoris a controlled wrapper: edits callonChange, and choosing an example replaces the document.Checks run locally: lint, typecheck, 4 unit tests, all 7 Playwright tests.