Repository navigation
Fetch the flow metadata once while the React SDK initializes - #120
Open
brionmario wants to merge 1 commit into
Open
brionmario wants to merge 1 commit into
brionmario wants to merge 1 commit into
Conversation
Signed-off-by: Brion <info@brionmario.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
FlowMetaProvidersends the sameGET /flow/metarequest up to three times on every page load when the app passes anapplicationIdup front, as the Gate's sign-in page does. Each response is about 190 kB, and the theme and translations it carries are applied once per response.The provider fetched every time its fetch callback was recreated. It fetches before ThunderID finishes initializing when an
applicationIdis known, and the callback is then recreated twice more while initialization settles: once whenisInitializedturns true, and once whenendpointsis replaced by the resolved configuration. None of those changes alter the request.Approach
fetchMetaoverride. It fetches only when that key changes, so a language switch still refetches while identity-only changes do not.applicationId), so the first request after initialization still goes out.initialMetaseeding.Related Issues
Related PRs
Checklist
breaking changelabel added.parity/prs-raisedorparity/prs-not-neededadded.parity/prs-raised, the port links are posted as a reply on the parity check's comment.Security checks